-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of glc->ocn coupling via going through mosart #463
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - I will work on the github test.
just noting: |
@mvertens - I just tried reproducing one of the tests you mentioned above. I got an error at preview_namelists time, saying that |
@billsacks Those names have been shortened to just ndens etc (drop the rtmhist_ part) I have it in my cesm sandbox, but haven't commited it yet. |
@mvertens, @gustavo-marques has some questions/concerns about this PR. I will send an invitation to meet to discuss on Monday. |
Description of changes
Specific notes
Contributors other than yourself, if any: None
CMEPS Issues Fixed: None
Are changes expected to change answers? Only for fully coupled compsets with active CISM and a greenland ice sheet, otherwise bfb
Any User Interface Changes? The following namelist variables and associated xml variables have been removed
ocn2glc_levels, glc2ocn_liq_rmapname, glc2ocn_ice_rmapname
GLC2ICE_RMAPNAME, GLC2OCN_LIQ_RMAPNAME, GLC2OCN_ICE_RMAPNAME
The following xml variables have been removed from config_component.xml since the only allowed values are idmap or unset which are now set in the namelist_definition_drv.xml file
Testing performed
Using cesm2_3_beta17 checkout with the following changes:
Verified that the following was bfb with cesm2_3_beta17 baseline
SMS_Ld2.f09_t232.B1850MOM.derecho_intel.mom-bcompset
Verified that the following had answer changes with cesm2_3_beta17 baselines (as expected)
SMS_Ld5.f09_g17.B1850G.derecho_intel.allactive-cism-test_coupling
Note that the