Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of glc->ocn coupling via going through mosart #463

Merged
merged 8 commits into from
Jun 24, 2024

Conversation

mvertens
Copy link
Collaborator

@mvertens mvertens commented Jun 7, 2024

Description of changes

Specific notes

  • This implements the GLC->OCN coupling by having GLC send the runoff ice and liquid fluxes to MOSART which are then routed directly to the outlet points and then mapped to the ocean using the nearest-neighbor plus smoothing custom files.
  • The code to map from GLC->ICE has been removed since there is no current code to implement this at the current time.

Contributors other than yourself, if any: None

CMEPS Issues Fixed: None

Are changes expected to change answers? Only for fully coupled compsets with active CISM and a greenland ice sheet, otherwise bfb

Any User Interface Changes? The following namelist variables and associated xml variables have been removed
ocn2glc_levels, glc2ocn_liq_rmapname, glc2ocn_ice_rmapname
GLC2ICE_RMAPNAME, GLC2OCN_LIQ_RMAPNAME, GLC2OCN_ICE_RMAPNAME

The following xml variables have been removed from config_component.xml since the only allowed values are idmap or unset which are now set in the namelist_definition_drv.xml file

  <entry id="ROF2OCN_FMAPNAME">
  <entry id="GLC2ICE_RMAPNAME">
  <entry id="GLC2OCN_LIQ_RMAPNAME">
  <entry id="GLC2OCN_ICE_RMAPNAME">
  <entry id="OCN2WAV_SMAPNAME">
  <entry id="ICE2WAV_SMAPNAME">
  <entry id="WAV2OCN_SMAPNAME">

Testing performed

Using cesm2_3_beta17 checkout with the following changes:

Verified that the following was bfb with cesm2_3_beta17 baseline
SMS_Ld2.f09_t232.B1850MOM.derecho_intel.mom-bcompset
Verified that the following had answer changes with cesm2_3_beta17 baselines (as expected)
SMS_Ld5.f09_g17.B1850G.derecho_intel.allactive-cism-test_coupling

Note that the

@mvertens mvertens requested a review from jedwards4b June 7, 2024 14:53
@mvertens mvertens marked this pull request as draft June 7, 2024 14:53
@mvertens mvertens marked this pull request as ready for review June 18, 2024 09:47
@mvertens mvertens requested a review from jedwards4b June 18, 2024 09:47
Copy link
Collaborator

@jedwards4b jedwards4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - I will work on the github test.

@slevis-lmwg
Copy link

just noting:
I think this PR will close #437

@jedwards4b jedwards4b merged commit f960f3e into ESCOMP:main Jun 24, 2024
2 checks passed
@billsacks
Copy link
Member

@mvertens - I just tried reproducing one of the tests you mentioned above. I got an error at preview_namelists time, saying that rtmhist_ndens (which appears in cime_config/testmods_dirs/allactive/defaultio/user_nl_mosart in the CESM repository) doesn't exist in MOSART's namelist definition any more. I can simply remove it for the test I'm doing, but is there a fix that should be put into CESM for this?

@jedwards4b
Copy link
Collaborator

@billsacks Those names have been shortened to just ndens etc (drop the rtmhist_ part) I have it in my cesm sandbox, but haven't commited it yet.

@jedwards4b
Copy link
Collaborator

@mvertens, @gustavo-marques has some questions/concerns about this PR. I will send an invitation to meet to discuss on Monday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants